Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List item ellipsize position #944

Merged
merged 4 commits into from
Mar 22, 2019
Merged

List item ellipsize position #944

merged 4 commits into from
Mar 22, 2019

Conversation

Darkmyr
Copy link
Contributor

@Darkmyr Darkmyr commented Mar 21, 2019 •
edited
Loading

Motivation

Ability to change the ellipsize position in the Title/Description of list items

Test plan

add the following to your list item properties and see that you can change the ellipses position in the following text elements.

titleEllipsizeMode='middle'
descriptionEllipsizeMode='middle'

image

@callstack-bot
Copy link

callstack-bot commented Mar 21, 2019 •
edited
Loading

Hey @Darkmyr, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API.

@ferrannp
Copy link
Collaborator

Thanks for your PR!

@ferrannp ferrannp merged commit 00457a9 into callstack:master Mar 22, 2019
@fabian-astorga fabian-astorga mentioned this pull request Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrannp ferrannp ferrannp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Darkmyr @callstack-bot @ferrannp