Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update types #842

Merged
merged 2 commits into from
Feb 17, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion typings/components/Avatar.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface ImageProps {
source: ImageSourcePropType;
size?: number;
style?: any;
them?: ThemeShape;
theme?: ThemeShape;
}

export declare class Image extends React.Component<ImageProps> {}
Expand All @@ -30,3 +30,9 @@ export interface TextProps {
}

export declare class Text extends React.Component<TextProps> {}

export declare class Avatar {
static Icon: Icon;
static Image: Image;
static Text: Text;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to your changes, but
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

1 change: 0 additions & 1 deletion typings/components/Card.d.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import * as React from 'react';

import { ImageProps, StyleProp, TextStyle, ViewProps, ViewStyle } from 'react-native';
import { StyledProps } from 'types/styled-components';

import { ThemeShape } from '../types';

Expand Down
2 changes: 2 additions & 0 deletions typings/components/ProgressBar.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import { ThemeShape } from '../types';

export interface ProgressBarProps {
progress: number;
animating?: boolean;
indeterminate?: boolean;
color?: string;
style?: any;
theme?: ThemeShape;
Expand Down