fix: textinput sizing for [email protected] #4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here. |
lukewalczak
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Looks like in
react-native-webfromv0.19.0texts must have specifiedlineHeightproperty, otherwise there are problems with sizing for absolutely positioned elements Checked other components and it looks like it only affects TextInput in our case.Fixed by adding default
lineHeightoffontSize * 1.2, this should work with our default font and most custom fonts as well. If user decides to use some esoteric font - there may be a need to specify customlineHeight.Fixes: #4041 #3825
Test plan
Tested for
[email protected](currently used in examples) andv0.19.8(latest). Seems to fix the issue, also does not affect iOs nor Android