Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom theme property for RadioButtonItem component #4036

Merged
merged 2 commits into from
Aug 21, 2023
Merged

fix: custom theme property for RadioButtonItem component #4036

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e348b1b
fix: use ThemeProp type for theme property in RadioButtonItem
alexzel Aug 18, 2023
3f434ee
fix: pass theme property down to components tree in RadioButtonItem
alexzel Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/components/RadioButton/RadioButtonItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
} from 'react-native';

import { useInternalTheme } from '../../core/theming';
import type { InternalTheme, MD3TypescaleKey } from '../../types';
import type { ThemeProp, MD3TypescaleKey } from '../../types';
import TouchableRipple from '../TouchableRipple/TouchableRipple';
import Text from '../Typography/Text';
import RadioButton from './RadioButton';
Expand Down Expand Up @@ -79,7 +79,7 @@ export type Props = {
/**
* @optional
*/
theme?: InternalTheme;
theme?: ThemeProp;
lukewalczak marked this conversation as resolved.
Show resolved Hide resolved
/**
* testID to be used on tests.
*/
Expand Down Expand Up @@ -135,7 +135,14 @@ const RadioButtonItem = ({
labelVariant = 'bodyLarge',
}: Props) => {
const theme = useInternalTheme(themeOverrides);
const radioButtonProps = { value, disabled, status, color, uncheckedColor };
const radioButtonProps = {
value,
disabled,
status,
color,
theme,
uncheckedColor,
};
const isLeading = position === 'leading';
let radioButton: any;

Expand Down