Draft: fix: conditionally import react navigation #3954
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3952
Summary
Unfortunately Webpack won't allows us to import missing export via ES6. Dynamic imports are a no-go as well. They're async and since we want to import hook we end up with
Promise<useLinkTools>
. This would break rules of hooks since we'd have a conditional hook rendered (before and after async import).The only solution I found is to import the whole package as
CommonJS
. This won't break the rules since it's sync. It will import once and then only one hook will be returned.Test plan
Example app does not throw an error anymore on either v6 or v7