fix: unfocused TextInput label disappears on new architecture (#3776) #3899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
TextInput
label disappears when the input is unfocused on React Native's New Architecture (on both Android and iOS). After some digging, I noticed the root cause is switching between anAnimated.Value
and somenumber
s depending on some booleans:If we switch between
Animated.Value
instances, the problem disappears:#3776 has more details about the issue and contains an example repo to reproduce it.
Test plan
https://github.com/ChrisGadek1/react-native-paper-textinput-bug-reproduction repo from #3776 (comment) can be used for testing this fix.