-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add event emit for long press #3769
Conversation
Hey @josemak25, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
The mobile version of example app from this branch is ready! You can see it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this needed to do is add onTabLongPress={({ route }) => navigation.emit({ type: 'tabLongPress', target: route.key })}
This abstraction is unnecessary. There's also no default action that happens on onLongPress
so canPreventDefault
doesn't do anything.
Noted making changes to this now |
Co-authored-by: Tomasz Janiczek <[email protected]>
Summary
Fixes event emitter for #3758
Test plan
yarn bootstrap
works