fix: input label positioning regression #3728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here. |
lukewalczak
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RNP v5.1.4 introduced regression in positioning of label on outlined TextInput:
This was caused by #3642. Reason:
Outlined TextInput uses additional mask to cover bigger round corners:
Working on performance of this component I decided to apply this mask only on outlined TextInput and only if the roundness is greater than 6pt. What I did not anticipated is that in V2 the this additional mask was used to cover left-most side of the label.
With this additional mask fixed, we can now unify math behind label for both V2 & V3. This should solve the issue.
Test plan
All outlined inputs were affected.