fix: fix position of menu when dimensions change

[mathias-berg]

Summary

The dimensions was set outside the component and therefore didn't change when the screen size was adjusted.
This was introduced in in rc9 so I just moved it back to where it was before when it worked.

Fixes #3515

[callstack-bot]

Hey @mathias-berg, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

[mathias-berg]

@lukewalczak
Is this solution good for you or should I change it to an event listener and set the values in state instead?

[lukewalczak]

Hey @mathias-berg, thanks for fix! We can stick with the current approach, however I would like to confirm whether it doesnt interfere with the previously fixed issue.

[lukewalczak]

Unfortunately, the current approach with updating window dimensions breaks the Menu example when opening the keyboard, from the previous issue, presented on that snack. Looks like we need to find another solution which covers both cases.

[mathias-berg]

I will look at this tonight to see if I find a solution.

[mathias-berg]

Did a lot of investigating on this last night and found a solution that works. I will do some more testing and then update this PR.

[mathias-berg]

Changes are up now, please have a look.

[lukewalczak]

Thanks @mathias-berg! I will review & test in my spare time

[lukewalczak]

Hey @mathias-berg, thanks for the help with fixing the issue! 🎉