Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prop pointerEvents for ListAccordion #3463

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

brunohkbx
Copy link
Collaborator

Summary

This component can receive a custom prop right, so the following code is allowed:

const renderRight = ({ isExpanded }) =>
(
    <IconButton
      icon={isExpanded ? 'chevron-up' : 'chevron-down'}
      size={24}
      onPress={myCustomOnPress}
    />
);

However, the onPress passed to the IconButton won't be triggered since the View container has a hard-coded pointerEvents="none"

Test plan

N/A

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@RichardLindhout
Copy link
Contributor

@arjendevos let's keep an eye on this (dd-trading) :)

Copy link
Member

@lukewalczak lukewalczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brunohkbx!

@lukewalczak lukewalczak merged commit f626652 into main Dec 19, 2022
@lukewalczak lukewalczak deleted the feat/add-pointer-events-to-accordion branch December 19, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants