Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct padding offset in TextInput on Android when RTL #3330

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

lukewalczak
Copy link
Member

Summary

Fixes: #3132

PR corrects padding passed to the InputLabel within TextInput on Android in the RTL mode.

before after
Zrzut ekranu 2022-08-22 o 14 29 16 Zrzut ekranu 2022-08-22 o 14 28 15

Test plan

Added tests.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak force-pushed the fix/text-input-rtl-label branch from 8518ce7 to ab48977 Compare September 2, 2022 08:51
@callstack-bot
Copy link

callstack-bot commented Sep 2, 2022

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak force-pushed the fix/text-input-rtl-label branch from ab48977 to 82bf9cb Compare September 5, 2022 08:52
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak merged commit 9d25227 into main Sep 5, 2022
@lukewalczak lukewalczak deleted the fix/text-input-rtl-label branch September 5, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect textinput label position in arabic locale
4 participants