Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct changing Dialog backdrop color (#3259) #3260

Merged
merged 4 commits into from
Aug 8, 2022

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Jul 18, 2022

Summary

PR is adjusting changes included in the PR to the main branch.

To override color backdrop color in FAB.Group the only way is to use backdropColor (supported on v4.x as well), since that color is different than typical backdrop used in Modal or Dialog.

At the same time, to the theme there was added backdrop color.

Test plan

Added tests.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@callstack-bot
Copy link

callstack-bot commented Jul 18, 2022

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

src/components/Modal.tsx Show resolved Hide resolved
src/components/Modal.tsx Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

The mobile version of example app from this branch is ready! You can see it here

.

@slavikdenis slavikdenis self-requested a review August 3, 2022 12:36
@lukewalczak lukewalczak merged commit 11686c5 into main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants