Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adjust TextInput #3108

Merged
merged 11 commits into from
May 30, 2022
Merged

feat: adjust TextInput #3108

merged 11 commits into from
May 30, 2022

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Mar 7, 2022 •
edited
Loading

Summary

PR adjusts TextInput into Material You. There are no changes in API, only visual changes.

Test plan

  • checked TextInput on:
    • both themes version
    • both color themes
    • both platforms
  • snapshots indicates there are no changes in the previous version

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak force-pushed the feat/adjust-text-input branch from fec9345 to 754ec46 Compare March 8, 2022 22:48
@callstack-bot
Copy link

callstack-bot commented Mar 8, 2022 •
edited
Loading

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak changed the title refactor: adjust TextInput feat: adjust TextInput Mar 9, 2022
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak force-pushed the feat/adjust-text-input branch from ff57091 to 4fa7f2d Compare March 14, 2022 21:01
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak force-pushed the feat/adjust-text-input branch from 4fa7f2d to cd6cec5 Compare March 27, 2022 15:47
@lukewalczak lukewalczak marked this pull request as ready for review March 27, 2022 15:49
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

p-syche
p-syche approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@p-syche p-syche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukewalczak - nicely done 👍 This is no trivial change 💪 Even though only 12 files were changed it looks like you had to think about a lot of moving parts.

I left a few comments and questions. However, as I checked on the Expo app, the TextInput works absolutely fine. So you can treat my comments as you like 🙇

src/components/TextInput/Adornment/TextInputIcon.tsx Show resolved Hide resolved
src/components/TextInput/Label/InputLabel.tsx Outdated Show resolved Hide resolved
src/components/TextInput/Label/LabelBackground.tsx Outdated Show resolved Hide resolved
src/components/TextInput/TextInputOutlined.tsx Outdated Show resolved Hide resolved
src/components/TextInput/helpers.tsx Outdated Show resolved Hide resolved
src/components/TextInput/helpers.tsx Outdated Show resolved Hide resolved
@lukewalczak lukewalczak force-pushed the feat/adjust-text-input branch from cd6cec5 to 3065ea4 Compare April 28, 2022 16:59
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

Drakeoon
Drakeoon approved these changes May 25, 2022
View reviewed changes
src/components/TextInput/helpers.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@Q1w1N Q1w1N self-requested a review May 30, 2022 12:48
Q1w1N
Q1w1N approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@Q1w1N Q1w1N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android and Ios. Looks good to me :)

@lukewalczak lukewalczak merged commit 22ce25d into next May 30, 2022
@lukewalczak lukewalczak deleted the feat/adjust-text-input branch May 30, 2022 16:26
lukewalczak added a commit that referenced this pull request Jun 8, 2022
@lukewalczak
feat: adjust TextInput (#3108)
b28c099
@oliviertassinari oliviertassinari mentioned this pull request Aug 23, 2022
Open
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Q1w1N Q1w1N Q1w1N approved these changes

@Drakeoon Drakeoon Drakeoon approved these changes

@p-syche p-syche p-syche approved these changes

Assignees
No one assigned
Labels
Material You (v5) TextInput
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lukewalczak @callstack-bot @p-syche @Drakeoon @Q1w1N