feat: adjust theme structure #3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewalczak
reviewed
Feb 8, 2022
| @@ -82,7 +82,10 @@ const DrawerItem = ({ | |||
| : 'transparent'; | |||
| const contentColor = active | |||
| ? colors?.primary | |||
There was a problem hiding this comment.
In cases where properties overlap i skipped the check, since it would be something like theme.isV3 ? theme.colors.primary : theme.colors.primary. In cases where it does matter, I use the full theme.colors.key syntax
Drakeoon
force-pushed
the
feat/adjust-theme-structure
branch
from
3de8a10 to
46f6e35
Compare
|
The mobile version of example app from this branch is ready! You can see it here |
lukewalczak
pushed a commit
that referenced
this pull request
Mar 22, 2022
lukewalczak
pushed a commit
that referenced
this pull request
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After internal discussion, we decided to simplify our approach and make the new theme closer to the old theme in terms of structure. This PR delivers that, plus it has all the necessary
theme.isV3 checksin componentsTest plan
Run the project locally:
yarn example start