Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct Chip touchable style #2976

Merged
merged 2 commits into from
Dec 10, 2021
Merged

fix: correct Chip touchable style #2976

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
798c2d7
fix: correct Chip touchable style
lukewalczak Nov 9, 2021
71f87d3
fix: allow content to grow, add new example
lukewalczak Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Chip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ const styles = StyleSheet.create({
alignItems: 'center',
},
touchable: {
flex: 1,
flexGrow: 1,
},
});

Expand Down
12 changes: 6 additions & 6 deletions src/components/__tests__/__snapshots__/Chip.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ exports[`renders chip with close button 1`] = `
"borderRadius": 16,
},
Object {
"flex": 1,
"flexGrow": 1,
},
],
]
Expand Down Expand Up @@ -263,7 +263,7 @@ exports[`renders chip with custom close button 1`] = `
"borderRadius": 16,
},
Object {
"flex": 1,
"flexGrow": 1,
},
],
]
Expand Down Expand Up @@ -485,7 +485,7 @@ exports[`renders chip with icon 1`] = `
"borderRadius": 16,
},
Object {
"flex": 1,
"flexGrow": 1,
},
],
]
Expand Down Expand Up @@ -634,7 +634,7 @@ exports[`renders chip with onPress 1`] = `
"borderRadius": 16,
},
Object {
"flex": 1,
"flexGrow": 1,
},
],
]
Expand Down Expand Up @@ -735,7 +735,7 @@ exports[`renders outlined disabled chip 1`] = `
"borderRadius": 16,
},
Object {
"flex": 1,
"flexGrow": 1,
},
],
]
Expand Down Expand Up @@ -836,7 +836,7 @@ exports[`renders selected chip 1`] = `
"borderRadius": 16,
},
Object {
"flex": 1,
"flexGrow": 1,
},
],
]
Expand Down
2 changes: 1 addition & 1 deletion src/components/__tests__/__snapshots__/ListItem.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ exports[`renders list item with custom description 1`] = `
"borderRadius": 16,
},
Object {
"flex": 1,
"flexGrow": 1,
},
],
]
Expand Down