Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: override Card surface colors with theme #2948

Merged
merged 1 commit into from
Oct 22, 2021
Merged

fix: override Card surface colors with theme #2948

merged 1 commit into from
Oct 22, 2021

Conversation

brunohkbx
Copy link
Collaborator

Summary

Resolve #2937

Test plan

<Card theme={{ colors: { surface: '#0000FF' } }}>
  <Card.Title title="Card Title" subtitle="Card Subtitle" />
  <Card.Cover source={{ uri: 'https://picsum.photos/700' }} />
  <Card.Actions>
    <Button>Cancel</Button>
    <Button>Ok</Button>
   </Card.Actions>
</Card>

after

@brunohkbx brunohkbx added the Card label Oct 22, 2021
@brunohkbx brunohkbx requested a review from lukewalczak October 22, 2021 14:36
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

lukewalczak
lukewalczak approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@lukewalczak lukewalczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lukewalczak lukewalczak merged commit 5821ee5 into main Oct 22, 2021
@lukewalczak lukewalczak deleted the fix/override-card-surface-with-theme branch October 22, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukewalczak lukewalczak lukewalczak approved these changes

Assignees
No one assigned
Labels
Card
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to overide card theme using theme variable
2 participants
@brunohkbx @lukewalczak