Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct displaying progress bar on Android #2916

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

lukewalczak
Copy link
Member

Summary

Nested ProgressBar sometimes has some issues with displaying properly the progress on the ProgressBar, because initial width is zero, then it's updated to the real value, however the component does not update itself. Making it conditionally fixes the problem.

On the screenshots you can observe:

  • left column presents fixed nested progress bar from the issue
  • right column presents all progressbar examples, to show that nothing breaks
fixed default progress bar examples
Zrzut ekranu 2021-10-6 o 13 39 45 Zrzut ekranu 2021-10-6 o 13 40 13

Test plan

  • Run the example app, open the ProgressBar and observe all the cases are working properly.

@github-actions
Copy link

github-actions bot commented Oct 6, 2021

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak requested a review from brunohkbx October 8, 2021 07:38
@lukewalczak lukewalczak requested a review from p-syche October 19, 2021 13:15
Copy link
Contributor

@p-syche p-syche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change to fix a big problem, nice!
thumbs-up-computer

@lukewalczak lukewalczak merged commit 452c163 into main Oct 20, 2021
@lukewalczak lukewalczak deleted the fix/progress-bar-nested-in-text branch October 20, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants