Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Styling of labels in FAB.Group #2894

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

haakandev
Copy link
Contributor

Summary

This PR adds properties for the FAB.Group actions to allow for custom styling of the FAB.Group labels.

Test plan

Provide labelTextColor and labelStyle properties in the FAB.Group's actions array.

@callstack-bot
Copy link

Hey @haakandev, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@andreialecu
Copy link
Contributor

I recently ended up using patch-package to add this and I was just about to open pretty much the exact same PR.

Please consider merging this.

@hefberk
Copy link

hefberk commented Sep 28, 2021

property fontSize doesn't seems working

@haakandev
Copy link
Contributor Author

property fontSize doesn't seems working

Hi @hefberk - the label component as is just uses a standard react-native-paper Text element. The labelStyle is actually for the wrapping View component. If desired, the change could be modified to take a labelTextStyle prop instead of labelTextColor to allow further customising of the label text.

Copy link
Member

@lukewalczak lukewalczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haakandev thanks!

@lukewalczak lukewalczak merged commit 656d652 into callstack:main Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants