Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: outlined TexInput adjustPaddingOut (#2740) #2793

Merged
merged 5 commits into from
Jul 1, 2021
Merged

fix: outlined TexInput adjustPaddingOut (#2740) #2793

merged 5 commits into from
Jul 1, 2021

Conversation

Kamalnrf
Copy link
Contributor

@Kamalnrf Kamalnrf commented Jun 26, 2021 •
edited
Loading

Summary

Fixes issue 2740. The issue happens to be when we calculate the adjustPaddingOut.

The change is to not return the centering paddingTop, and paddingBottom in case it is multiline.

Test plan

Screen Shot 2021-06-30 at 23 10 26

@callstack-bot
Copy link

callstack-bot commented Jun 26, 2021 •
edited
Loading

Hey @Kamalnrf, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@brunohkbx
Copy link
Collaborator

Reviewing this PR I noticed that currently, both flat and outline multiline TextInput differ from each other.

Flat Outlined
flat outlined

Per MD specs and in this example it shouldn't be centered.

Screenshot from 2021-06-30 11-54-46

Fixed(iOS) Fixed(Android)
ios android

I can confirm this PR fixes #2730 as well. Applying padding makes it scrollable.

@brunohkbx brunohkbx linked an issue Jun 30, 2021 that may be closed by this pull request
TextInput content scrolls in outlined mode on Android #2730
Closed
@brunohkbx
Copy link
Collaborator

@Kamalnrf can you update the PR description? It should be an outlined textinput rather than a flat one.

@brunohkbx brunohkbx linked an issue Jun 30, 2021 that may be closed by this pull request
TextInput multiline problem when giving a fixed height #2740
Closed
@brunohkbx brunohkbx merged commit 60e99dd into callstack:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunohkbx brunohkbx brunohkbx approved these changes

Assignees
No one assigned
Labels
bug TextInput
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextInput multiline problem when giving a fixed height TextInput content scrolls in outlined mode on Android
3 participants
@Kamalnrf @callstack-bot @brunohkbx