fix: list.accordion onlongpress type #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently List.Accordion onLongPress prop has a type
() => void. List.Accordion pasess this to TouchableRipple in which the type of onLongPress is(e: GestureResponderEvent) => void. When using the List.Accordion component it does passes GestureResponderEvent but since the type does not have any parameters defined the linter complains about it. List.Item uses the same type as TouchableRipple.The GestureResponderEvent could be used to correclty locate a contextual menu over the Accordion which will be a diferent callback from onPress (expand)
Test plan
Currently this works, is just the linter since it passes the prop but the linter complains about it.
Passes type-check, lint and tests. Reviewed Docs as well.