Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List.accordion no titleStyle? #973

Closed
Unicity-Pimentel opened this issue Apr 4, 2019 · 1 comment · Fixed by #997 · May be fixed by fabian-astorga/my-house-rpi#2
Closed

List.accordion no titleStyle? #973

Unicity-Pimentel opened this issue Apr 4, 2019 · 1 comment · Fixed by #997 · May be fixed by fabian-astorga/my-house-rpi#2
Assignees
@jayu
Labels
enhancement good first task

Comments

@Unicity-Pimentel
Copy link

Unicity-Pimentel commented Apr 4, 2019 •
edited
Loading

I created a page using List.Section,Accordion and Item where when the List.accordion and List.Item is pressed it will automatically update its styles (font color, bg color). So far the List.Item is the only one working properly atm. Any suggestions on this ?
@Unicity-Pimentel Unicity-Pimentel changed the title List.section no titleStyle? List.accordion no titleStyle? Apr 4, 2019
@jayu
Copy link
Contributor

jayu commented Apr 15, 2019

It looks like a missing feature. I think we can add titleStyle and descriptionStyle to List.Accordion and titleStyle to List.Section. @Unicity-Pimentel you know, PRs are welcome if you have some time :D. Just let others know whether you work on it or no. I could probably take it within a few days.

@jayu jayu mentioned this issue Apr 16, 2019
Merged
ferrannp pushed a commit that referenced this issue Apr 25, 2019
@jayu @ferrannp
feat: missing titleStyle and descriptionStyle for List.Accordion and …
e6d8ccf 
…List.Section (#997)

This PR introduces missing style props:
List.Accordion:
- `titleStyle`
- `descriptionStyle`

List.Section
- `titleStyle`

Also improves `style` prop type and description in these components.

### Motivation
Fixes #973
iyadthayyil pushed a commit to iyadthayyil/react-native-paper that referenced this issue Jun 6, 2019
@jayu @iyadthayyil
feat: missing titleStyle and descriptionStyle for List.Accordion and …
4e7f3f4 
…List.Section (callstack#997)

This PR introduces missing style props:
List.Accordion:
- `titleStyle`
- `descriptionStyle`

List.Section
- `titleStyle`

Also improves `style` prop type and description in these components.

### Motivation
Fixes callstack#973
Trancever pushed a commit that referenced this issue Jun 27, 2019
@jayu @Trancever
feat: missing titleStyle and descriptionStyle for List.Accordion and …
4974b8c 
…List.Section (#997)

This PR introduces missing style props:
List.Accordion:
- `titleStyle`
- `descriptionStyle`

List.Section
- `titleStyle`

Also improves `style` prop type and description in these components.

Fixes #973
@fabian-astorga fabian-astorga mentioned this issue Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayu jayu

Labels
enhancement good first task
Projects
None yet
Milestone
No milestone
3 participants
@ferrannp @jayu @Unicity-Pimentel