fix: textinput long text causes wrapping (ios) #4261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Release 5.10.5 introduced #4084 which created a bug in TextInput (iOS) when there is a long text value.
iOS has a specific style requirement (possibly related) for TextInput to show the ellipsis and not wrap when there is a long text value.
#4084 prevents lineHeight having "undefined" as a possible value. Given that #4084 was specifically only addressing web requirements, this pull request introduces a web platform check.
Related issue
Fixes: #2581
Test plan
Have written an example TextInput component to test for expected iOS behaviour.
Requesting some assistance in writing the Jest test.