Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move outline outside of input view container #2997

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Dec 7, 2021

Fixes: #2935

Summary

PR moves the outline outside of TextInput, so then it's not affected by input's padding.

ios android web
input_padding_ios Kapture 2021-12-09 at 14 54 54 Kapture 2021-12-09 at 14 57 41

Test plan

  1. To one of TextInput example with mode="outlined" add to styles some paddingRight or use the following snippet:
      <TextInput
        label="Email"
        placeholder="Email"
        value={text}
        multiline={false}
        mode="outlined"
        onChangeText={(text) => setText(text)}
        style={{ backgroundColor: 'aquamarine', paddingRight: 120 }}
      />
  1. Type some text
  2. Expect padding is adjusted properly

@lukewalczak lukewalczak mentioned this pull request Dec 7, 2021
@callstack-bot
Copy link

callstack-bot commented Dec 7, 2021

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak marked this pull request as ready for review December 9, 2021 14:54
@lukewalczak lukewalczak force-pushed the fix/outlined-input-padding branch from d8cd376 to c5b8d6e Compare December 10, 2021 14:06
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextInput padding
2 participants