Skip to content

Commit

Permalink
fix: move outline outside of input view container
Browse files Browse the repository at this point in the history
  • Loading branch information
lukewalczak committed Dec 7, 2021
1 parent b545cdc commit d8cd376
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 27 deletions.
14 changes: 7 additions & 7 deletions src/components/TextInput/TextInputOutlined.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -291,14 +291,14 @@ class TextInputOutlined extends React.Component<ChildTextInputProps> {
This is so that the label can overlap the outline
Otherwise the border will cut off the label on Android
*/}
<Outline
theme={theme}
hasActiveOutline={hasActiveOutline}
activeColor={activeColor}
outlineColor={outlineColor}
backgroundColor={backgroundColor}
/>
<View>
<Outline
theme={theme}
hasActiveOutline={hasActiveOutline}
activeColor={activeColor}
outlineColor={outlineColor}
backgroundColor={backgroundColor}
/>
<View
style={[
styles.labelContainer,
Expand Down
40 changes: 20 additions & 20 deletions src/components/__tests__/__snapshots__/TextInput.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -181,27 +181,27 @@ exports[`correctly applies height to multiline Outline TextInput 1`] = `
<View
style={Object {}}
>
<View
pointerEvents="none"
style={
Array [
Object {
"bottom": 0,
"left": 0,
"position": "absolute",
"right": 0,
"top": 6,
},
Object {
"backgroundColor": "#f6f6f6",
"borderColor": "rgba(0, 0, 0, 0.54)",
"borderRadius": 4,
"borderWidth": 1,
},
]
}
/>
<View>
<View
pointerEvents="none"
style={
Array [
Object {
"bottom": 0,
"left": 0,
"position": "absolute",
"right": 0,
"top": 6,
},
Object {
"backgroundColor": "#f6f6f6",
"borderColor": "rgba(0, 0, 0, 0.54)",
"borderRadius": 4,
"borderWidth": 1,
},
]
}
/>
<View
style={
Array [
Expand Down

0 comments on commit d8cd376

Please sign in to comment.