refactor: correct elevation

callstack · Apr 15, 2022 · 2be5266 · 2be5266
1 parent 237f682
commit 2be5266
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/example/src/Examples/MenuExample.tsx b/example/src/Examples/MenuExample.tsx
@@ -67,7 +67,7 @@ const MenuExample = ({ navigation }: Props) => {
             <Appbar.Action
               icon={MORE_ICON}
               onPress={_toggleMenu('menu1')}
-              {...(isV3 && { color: 'white' })}
+              {...(!isV3 && { color: 'white' })}
             />
           }
         >

diff --git a/src/components/Menu/Menu.tsx b/src/components/Menu/Menu.tsx
@@ -530,7 +530,8 @@ class Menu extends React.Component<Props, State> {
     const shadowMenuContainerStyle = {
       opacity: opacityAnimation,
       transform: scaleTransforms,
-      borderRadius: theme.isV3 ? 4 : theme.roundness,
+      borderRadius: theme.roundness,
+      ...(!theme.isV3 && { elevation: 8 }),
       ...(scrollableMenuHeight ? { height: scrollableMenuHeight } : {}),
     };
 
@@ -572,7 +573,6 @@ class Menu extends React.Component<Props, State> {
                     [
                       styles.shadowMenuContainer,
                       shadowMenuContainerStyle,
-                      theme.isV3 && styles.md3ShadowMenuContainer,
                       theme.isV3 && {
                         backgroundColor: color(theme.colors.surface)
                           .mix(color(theme.colors.primary), 0.08)
@@ -582,6 +582,7 @@ class Menu extends React.Component<Props, State> {
                       contentStyle,
                     ] as StyleProp<ViewStyle>
                   }
+                  {...(theme.isV3 && { elevation: 2 })}
                 >
                   {(scrollableMenuHeight && (
                     <ScrollView>{children}</ScrollView>
@@ -603,10 +604,6 @@ const styles = StyleSheet.create({
   shadowMenuContainer: {
     opacity: 0,
     paddingVertical: 8,
-    elevation: 8,
-  },
-  md3ShadowMenuContainer: {
-    elevation: 3,
   },
 });