Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add android pageMargin #256

Merged
merged 1 commit into from
Dec 2, 2020
Merged

fix: add android pageMargin #256

merged 1 commit into from
Dec 2, 2020

Conversation

MateWW
Copy link
Contributor

@MateWW MateWW commented Dec 2, 2020

Fix for issue #231

Test Plan

image

What are the steps to reproduce (after prerequisites)?

Prepare testing component with this body:

      <SafeAreaView style={{flex: 1, backgroundColor: 'white'}}>
        <ViewPager pageMargin={24} style={{flex: 1}}>
          <View style={{flex: 1, backgroundColor: 'red'}} />
          <View style={{flex: 1, backgroundColor: 'blue'}} />
        </ViewPager>
        <View style={{flex: 1, backgroundColor: 'yellow'}} />
        <ViewPager pageMargin={24} style={{flex: 1}} orientation="vertical">
          <View style={{flex: 1, backgroundColor: 'green'}} />
          <View style={{flex: 1, backgroundColor: 'tomato'}} />
        </ViewPager>
      </SafeAreaView>

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator

@troZee troZee merged commit e613add into next Dec 2, 2020
troZee pushed a commit that referenced this pull request Dec 2, 2020
@troZee troZee deleted the fix/next/android-pageMargin branch November 17, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants