-
Notifications
You must be signed in to change notification settings - Fork 191
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: use proper codegen types (#697)
### Summary We were using `type: "all"` in codegenConfig for all types of libraries. @cipolleschi recommended us to use proper types instead [in this thread](facebook/react-native#46208 (comment)). This updates the templates to use the proper types ### Test plan #### Modules 1. Create a new arch supported module library 2. Go to the `package.json` and make sure `codegenConfig.type` is `"modules"` 3. Make sure the library builds and runs fine with the new architecture #### Components a.k.a views 1. Create a new arch supported view/component 2. Go to the `package.json` and make sure `codegenConfig.type` is `"components"` 3. 3. Make sure the library builds and runs fine with the new architecture
- Loading branch information
Showing
4 changed files
with
32 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters