Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stylis resolve plugin #195

Closed
wants to merge 7 commits into from
Closed

Stylis resolve plugin #195

wants to merge 7 commits into from

Conversation

zamotany
Copy link
Contributor

Fixes #182

@codecov
Copy link

codecov bot commented Jan 16, 2018 •
edited
Loading

Codecov Report

Merging #195 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   97.64%   97.74%   +0.09%     
==========================================
  Files          19       20       +1     
  Lines         425      443      +18     
  Branches       90       95       +5     
==========================================
+ Hits          415      433      +18     
  Misses         10       10
Impacted Files Coverage Δ
src/babel/preval-extract/prevalStyles.js 100% <100%> (ø) ⬆️
src/tools/stylisResolvePlugin.js 100% <100%> (ø)
src/sheet.js 96.15% <100%> (+0.15%) ⬆️
src/babel/lib/moduleSystem.js 98.78% <100%> (+0.09%) ⬆️
src/babel/rewire-imports/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce0a61c...a878c61. Read the comment docs.

satya164
satya164 reviewed Jan 22, 2018
View reviewed changes
src/babel/lib/moduleSystem.js Outdated
exports: any,
isDefault: boolean = false
) {
const moduleInstance = new Module(`@linaria/${moduleId}`, null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is provideModule used for?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It holds a reference to real file so it's possible to get the relative path. We've discussed about @zamotany recently that it's maybe better to change the module name to something like @linaria-internal-somehash so it's impossible for someone to mistakenly require it)

@zamotany zamotany closed this Sep 20, 2018
satya164 added a commit that referenced this pull request Oct 12, 2018
@satya164
fix: support usage with file-loader
28e0051 
This commit adds a plugin to replace relative paths inside url(..) expressions to be relative to the output file so that they can be resolved properly with css-loader.

It also changes the output folder to be 'node_modules/.linaria-cache' like before.

Inspired by #195
Fixes #182
@satya164 satya164 mentioned this pull request Oct 12, 2018
Merged
satya164 added a commit that referenced this pull request Oct 12, 2018
@satya164
fix: support usage with file-loader
845ac38 
This commit adds a plugin to replace relative paths inside url(..) expressions to be relative to the output file so that they can be resolved properly with css-loader.

It also changes the output folder to be 'node_modules/.linaria-cache' like before.

Inspired by #195
Fixes #182
satya164 added a commit that referenced this pull request Oct 12, 2018
@satya164
fix: support usage with file-loader
e43f47a 
This commit adds a plugin to replace relative paths inside url(..) expressions to be relative to the output file so that they can be resolved properly with css-loader.

It also changes the output folder to be 'node_modules/.linaria-cache' like before.

Inspired by #195
Fixes #182
satya164 added a commit that referenced this pull request Oct 12, 2018
@satya164
fix: support usage with file-loader
609ddc0 
This commit adds a plugin to replace relative paths inside url(..) expressions to be relative to the output file so that they can be resolved properly with css-loader.

It also changes the output folder to be 'node_modules/.linaria-cache' like before.

Inspired by #195
Fixes #182
satya164 added a commit that referenced this pull request Oct 12, 2018
@satya164
fix: support usage with file-loader
f37ba20 
This commit adds a plugin to replace relative paths inside url(..) expressions to be relative to the output file so that they can be resolved properly with css-loader.

It also changes the output folder to be 'node_modules/.linaria-cache' like before.

Inspired by #195
Fixes #182
satya164 added a commit that referenced this pull request Oct 12, 2018
@satya164
fix: support usage with file-loader
04d3e47 
This commit adds a plugin to replace relative paths inside url(..) expressions to be relative to the output file so that they can be resolved properly with css-loader.

It also changes the output folder to be 'node_modules/.linaria-cache' like before.

Inspired by #195
Fixes #182
satya164 added a commit that referenced this pull request Oct 14, 2018
@satya164
fix: support usage with file-loader
647cf70 
This commit adds a plugin to replace relative paths inside url(..) expressions to be relative to the output file so that they can be resolved properly with css-loader.

It also changes the output folder to be 'node_modules/.linaria-cache' like before.

Inspired by #195
Fixes #182
satya164 added a commit that referenced this pull request Oct 14, 2018
@satya164
fix: support usage with file-loader
e651f8b 
This commit adds a plugin to replace relative paths inside url(..) expressions to be relative to the output file so that they can be resolved properly with css-loader.

It also changes the output folder to be 'node_modules/.linaria-cache' like before.

Inspired by #195
Fixes #182
satya164 added a commit that referenced this pull request Oct 14, 2018
@satya164
fix: support usage with file-loader
6a43ddd 
This commit adds a plugin to replace relative paths inside url(..) expressions to be relative to the output file so that they can be resolved properly with css-loader.

It also changes the output folder to be 'node_modules/.linaria-cache' like before.

Inspired by #195
Fixes #182
satya164 added a commit that referenced this pull request Oct 15, 2018
@satya164
fix: support usage with file-loader
2cc5670 
This commit adds a plugin to replace relative paths inside url(..) expressions to be relative to the output file so that they can be resolved properly with css-loader.

It also changes the output folder to be 'node_modules/.linaria-cache' like before.

Inspired by #195
Fixes #182
@satya164 satya164 deleted the fix/stylis-resolve-plugin branch January 11, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee left review comments

@satya164 satya164 satya164 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zamotany @satya164 @thymikee