Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recursively check for variable declarator #155

Merged
merged 1 commit into from
Oct 26, 2017

Conversation

satya164
Copy link
Member

@satya164 satya164 commented Oct 25, 2017

This allows to have the template literal inside expressions such as function calls before assigning to a variable.

For example, one could write helper function to generate components with already assigned class names,

const Header = styled('h1', css`
  font-weight: bold;
`);

This allows to have the template literal inside expressions such as function calls before assigning to a variable.

For example, one could write helper function to generate components with already assigned tag names,

```js
const Header = styled('h1', css`
  font-weight: bold;
`);
```
@satya164 satya164 force-pushed the @satya164/variable-assignment branch from c7d5469 to 6a16125 Compare October 25, 2017 18:41
@codecov
Copy link

codecov bot commented Oct 25, 2017

Codecov Report

Merging #155 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   97.52%   97.53%   +0.01%     
==========================================
  Files          19       19              
  Lines         404      406       +2     
  Branches       81       83       +2     
==========================================
+ Hits          394      396       +2     
  Misses         10       10
Impacted Files Coverage Δ
src/babel/preval-extract/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 293c00a...6a16125. Read the comment docs.

@satya164 satya164 requested a review from zamotany October 25, 2017 18:42
@zamotany zamotany merged commit 6d3a125 into master Oct 26, 2017
@zamotany zamotany deleted the @satya164/variable-assignment branch October 26, 2017 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants