fix: Append classnames when extracting to single file #115
Conversation
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 97.65% 97.67% +0.02%
==========================================
Files 18 18
Lines 341 344 +3
Branches 59 60 +1
==========================================
+ Hits 333 336 +3
Misses 8 8
Continue to review full report at Codecov.
|
| @@ -56,6 +56,37 @@ describe('preval-extract/extractStyles module', () => { | |||
| expect(writeFileSync).not.toHaveBeenCalled(); | |||
| }); | |||
|
|
|||
| it('should append classnames when writing to single file', () => { | |||
There was a problem hiding this comment.
This test case is a duplication of
There was a problem hiding this comment.
not quite, as that other test doesn't test for appending stylesheets, just calling it once.
There was a problem hiding this comment.
You should update this one
There was a problem hiding this comment.
my bad, then move your case to with cache enabled describe block
| if (hasCachedStyles(currentFilename, data)) { | ||
| return; | ||
| } | ||
| stylesCache[currentFilename] = data; |
There was a problem hiding this comment.
that's the issue, filename is always the same when { single: true, filename: styles.css } and get's overwritten
There was a problem hiding this comment.
shouldn't it be currentFilePath?
There was a problem hiding this comment.
Hm, this got me thinking, that if this path is not absolute, we need to process it through parseCurrentFilename, otherwise we can overwrite cache of 2 unrelated files which have the same names. I'll post a followup later.
Summary
When extracting with
{single: true}option, classnames were overwritten instead of appended.Test plan
Added a test that verifies proper behavior.