Add a HTML containter for locked FreeText annotations in order to be …

…able to display a popup (follow-up iof mozilla#17070)
calixteman · Oct 5, 2023 · e737638 · e737638
1 parent c4c24c6
commit e737638
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/core/annotation.js b/src/core/annotation.js
@@ -3724,6 +3724,8 @@ class FreeTextAnnotation extends MarkupAnnotation {
     // But if it has the noHTML flag, it means that we don't want to be able
     // to modify it so we can just draw it on the main canvas.
     this.data.hasOwnCanvas = !this.data.noHTML;
+    // We want to be able to add mouse listeners to the annotation.
+    this.data.noHTML = false;
 
     const { evaluatorOptions, xref } = params;
     this.data.annotationType = AnnotationType.FREETEXT;

diff --git a/src/display/annotation_layer.js b/src/display/annotation_layer.js
@@ -671,7 +671,14 @@ class AnnotationElement {
     }
   }
 
+  get _isEditable() {
+    return false;
+  }
+
   _editOnDoubleClick() {
+    if (!this._isEditable) {
+      return;
+    }
     const {
       annotationEditorType: mode,
       data: { id: editId },
@@ -2347,6 +2354,10 @@ class FreeTextAnnotationElement extends AnnotationElement {
 
     return this.container;
   }
+
+  get _isEditable() {
+    return this.data.hasOwnCanvas;
+  }
 }
 
 class LineAnnotationElement extends AnnotationElement {