Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bluebird Removal): Remove Bluebird from index #88

Merged
merged 9 commits into from
Aug 24, 2022

Conversation

Thexumaker
Copy link
Contributor

@Thexumaker Thexumaker commented Aug 21, 2022

Description

  • Removes the last of Bluebird
  • Adds extra testing for error handling
  • Updates devDeps

Concerns

I'm not gonna lie, I'm not sure I'm handling the callbacks correctly :/

lib/index.js Outdated
return measurement;
}
catch (err) {
if (callback) return err;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean if (!callback) throw err; here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yea good catch

@Thexumaker Thexumaker merged commit e145ebc into main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants