Fix missing embed folder in web/public
#364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariombalhara
changed the title
embed folder in web/public
hariombalhara
force-pushed
the
fix-embed-build
branch
from
12a2891 to
ae419fe
Compare
hariombalhara
commented
Jun 10, 2024
| @@ -32,6 +32,8 @@ RUN npx turbo prune --scope=@calcom/web --docker | |||
| RUN yarn install | |||
| RUN yarn db-deploy | |||
| RUN yarn --cwd packages/prisma seed-app-store | |||
| # Build and make embed servable from web/public/embed folder | |||
| RUN yarn --cwd packages/embeds/embed-core workspace @calcom/embed-core run build | |||
| RUN yarn --cwd apps/web workspace @calcom/web run build | |||
There was a problem hiding this comment.
Note: Docker build was failing for me at @calcom/web run build command(due to type check) and it is unrelated to this change. I got the build passing through by adding CI=1 env variable for line 37.
alishaz-polymath
approved these changes
Jul 11, 2024
keithwillcode
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #360
Possible regression from #359. As we stopped using
turbofor build,embed-coredependency of @calcom/web stopped building causing thepublic/embedfolder to be not generated.