Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Duration select dropdown multiple durations email embed #17432

Merged
merged 3 commits into from
Feb 19, 2025
Merged

feat: Duration select dropdown multiple durations email embed #17432

merged 3 commits into from
Feb 19, 2025

Conversation

Amit91848
Copy link
Contributor

What does this PR do?

Screencast.from.2024-11-01.19-20-45.webm

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel Vercel
Copy link

vercel bot commented Nov 1, 2024

@Amit91848 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added embed area: embed, widget, react embed Low priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Nov 1, 2024
@dosubot dosubot bot added the ✨ feature New feature or request label Nov 1, 2024
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Nov 1, 2024
@graphite-app graphite-app bot requested a review from a team November 1, 2024 13:55
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 1, 2024 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/01/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (11/01/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (11/19/24)

1 label was added to this PR based on Keith Williams's automation.

@Praashh Praashh self-assigned this Nov 1, 2024
@keithwillcode keithwillcode added this to the v4.7 milestone Nov 3, 2024
@keithwillcode
Copy link
Contributor

@hariombalhara Can you please review this one. 🙏

@keithwillcode keithwillcode modified the milestones: v4.7, v4.8 Nov 18, 2024
@dosubot dosubot bot modified the milestones: v4.7, v4.8 Nov 18, 2024
Praashh
Praashh approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024 •
edited
Loading

E2E results are ready!

anikdhabal
anikdhabal requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for Hariom's review

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Dec 4, 2024
@keithwillcode keithwillcode modified the milestones: v4.8, v4.9 Dec 15, 2024
@dosubot dosubot bot modified the milestone: v4.9 Dec 15, 2024
@github-actions github-actions bot removed the Stale label Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Dec 31, 2024
@github-actions github-actions bot removed the Stale label Jan 12, 2025
@dosubot dosubot bot modified the milestones: v4.9, v4.10 Jan 16, 2025
@keithwillcode keithwillcode modified the milestones: v4.9, v5.0 Jan 16, 2025
@dosubot dosubot bot modified the milestones: v5.0, v4.10 Jan 16, 2025
@Amit91848 Amit91848 requested a review from anikdhabal February 5, 2025 15:30
@dosubot dosubot bot modified the milestones: v4.10, v5.1 Feb 17, 2025
anikdhabal
anikdhabal approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@anikdhabal anikdhabal enabled auto-merge (squash) February 19, 2025 12:23
@anikdhabal anikdhabal merged commit 984ccf7 into calcom:main Feb 19, 2025
31 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anikdhabal anikdhabal anikdhabal approved these changes

@Praashh Praashh Praashh approved these changes

@hariombalhara hariombalhara Awaiting requested review from hariombalhara

Assignees

@Praashh Praashh

Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync embed area: embed, widget, react embed ✨ feature New feature or request Low priority Created by Linear-GitHub Sync ready-for-e2e
Projects
None yet
Milestone
v5.1
Development

Successfully merging this pull request may close these issues.

[CAL-4594] Dropdown to select the durattion on email embed does not work
4 participants
@Amit91848 @keithwillcode @anikdhabal @Praashh