51-create-forgot-password-flow #79
Open
+149
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachaelch3n
changed the title
kaleenchen
reviewed
Mar 2, 2025
app/(auth)/forgot-password/page.tsx
Outdated
| ); | ||
| }; | ||
|
|
||
| const isValidEmail = (email: string): boolean => { |
There was a problem hiding this comment.
isValidEmail can be outside component because not needed for component state / dont need to render each time
kaleenchen
reviewed
Mar 2, 2025
| @@ -0,0 +1,35 @@ | |||
| 'use client'; | |||
There was a problem hiding this comment.
yay!! everything honestly looks good! <3
|
everything looks great, great job!! just a couple things:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR 🧑🌾
Description
Screenshots
How to review
Edited login page, created email-sent and forgot-password page, and lib/icons (for the back arrow icon). Confirm that you only receive an email from supabase if your account is registered.
Next steps
Might include message on email-sent page that states if the user didn't receive an email from supabse, then either the account isn't registered or the user input the email wrong.
Relevant links
Online sources
Related PRs
CC: @ccatherinetan