Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.21.6 #1389

Merged
merged 21 commits into from
Sep 5, 2018
Merged

Release/0.21.6 #1389

merged 21 commits into from
Sep 5, 2018

Conversation

AlexWellsHS
Copy link
Contributor

@AlexWellsHS AlexWellsHS commented Aug 15, 2018

0.21.6

TODO

  • Update version to 0.21.6 in podspec
  • Replace references to RunLoop::SimControl with some other RunLoop method.

@jmoody
Copy link
Contributor

jmoody commented Aug 16, 2018

Jenkins test this please

@jmoody jmoody added this to the 0.21.6 milestone Aug 16, 2018
@jmoody
Copy link
Contributor

jmoody commented Aug 30, 2018

@AlexWellsHS

Update the run_loop dependency version:

https://github.com/calabash/calabash-ios/blob/develop/calabash-cucumber/calabash-cucumber.gemspec#L62

s.add_dependency("run_loop", ">= 3.0", "< 4.0")

I think you will then see which rspec tests are failing.

All references to RunLoop::SimControl can be replaced with some other RunLoop method.

If you have any questions, just ask here or in Gitter.

Calabash.podspec Outdated
@@ -2,7 +2,7 @@
Pod::Spec.new do |s|

s.name = 'Calabash'
s.version = '0.21.4'
s.version = '0.21.5'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to 0.21.6

@AlexWellsHS
Copy link
Contributor Author

@jmoody not sure about commit f72a770. running rbenv exec bundle exec rspec spec/lib spec/bin spec/integration passes every test besides calabash_sim_accessibility. any advice would be much appreciated.

@jmoody
Copy link
Contributor

jmoody commented Aug 31, 2018

def calabash_sim_accessibility
detect_accessibility_support

Delete these methods and any callers.

There are no replacements and enabling accessibility is no longer necessary.

As you have noticed, the CLI is not a good shape.

@AlexWellsHS
Copy link
Contributor Author

@jmoody all tests passing. am i able to kick off jenkins myself?

@AlexWellsHS
Copy link
Contributor Author

Jenkins test this please

@jmoody
Copy link
Contributor

jmoody commented Sep 3, 2018

@AlexWellsHS

The Jenkins tests have not run automatically because of some permissions problems.

The "green check box" indicates that you have signed the MSFT OSS agreement.

I have added you as a contributor. You will need to accept the invitation. This should allow Jenkins to run the tests automatically.

@AlexWellsHS
Copy link
Contributor Author

@jmoody shall i follow the Release Docs from here?

@jmoody
Copy link
Contributor

jmoody commented Sep 4, 2018

@AlexWellsHS Those docs look out of date. I will handle from here.

@jmoody
Copy link
Contributor

jmoody commented Sep 5, 2018

@AlexWellsHS Looking at this again, you need to do the merge from your fork AlexWellsHS:release/0.21.6 back into calabash:develop. I think you have permission to do this.

Now that you are a maintainer, it will be easier for you to work from the calabash/calabash-ios project (not from your fork).

@jmoody jmoody merged commit 603acef into calabash:master Sep 5, 2018
@AlexWellsHS
Copy link
Contributor Author

@jmoody cant i just make a PR from master to develop since this was merged into master?
also, you told me to remind you to update the readme.md after the release.

@jmoody
Copy link
Contributor

jmoody commented Sep 5, 2018

You must merge release/0.21.6 into develop.

remind me

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants