Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability uia timeout/lost write/read #89

Merged
merged 6 commits into from
Nov 4, 2014
Merged

Conversation

krukow
Copy link
Contributor

@krukow krukow commented Nov 3, 2014

This pull request enables extended measures to mitigate the issue of lost writes and reads to preferences across the UIA process and Calabash (see calabash/calabash-ios#585).

# Work in process - do not merge (yet)

@jmoody says "Good enough to merge into develop."

We will do a number of pre-releases of the server component to measure the effect of the mitigation so we can conclude if we're looking at a fix or not.

There are another of set of routes we can go down if not.

@krukow
Copy link
Contributor Author

krukow commented Nov 3, 2014

Doing a 0.11.4.pre1 to distribute to select users that have reported the issue.

Joshua Moody & Michael Kirk added 4 commits November 4, 2014 01:49
An incredibly ugly diff that does one thing:  detect Xcode 6.1
+ iOS 8.1 and branch to run special validation code.  Otherwise
do what we have always done; write the preferences plist.
Matches the rest of the constants in the file.
@jmoody
Copy link
Contributor

jmoody commented Nov 4, 2014

These changes fix hanging on iOS 7.1 simulators.

Tests

  • animated-happiness/chou
$ DEVELOPER_DIR=/Xcode/6.1/Xcode.app/Contents/Developer script/ci/travis/local-run-as-travis.rb 
$ DEVELOPER_DIR=/Xcode/6.0.1/Xcode.app/Contents/Developer script/ci/travis/local-run-as-travis.rb 
$ DEVELOPER_DIR=/Xcode/5.1.1/Xcode.app/Contents/Developer script/ci/travis/local-run-as-travis.rb 

@krukow I think this is worth merging to develop for more testing.

@jmoody
Copy link
Contributor

jmoody commented Nov 4, 2014

@krukow Merging. Will be running a bunch of tests today and I don't want this branch to become stranded.

jmoody added a commit that referenced this pull request Nov 4, 2014
WIP: Stability uia timeout/lost write/read - Do not merge
@jmoody jmoody merged commit 1034cc9 into develop Nov 4, 2014
@jmoody jmoody changed the title WIP: Stability uia timeout/lost write/read - Do not merge WIP: Stability uia timeout/lost write/read Nov 4, 2014
@jmoody jmoody changed the title WIP: Stability uia timeout/lost write/read Stability uia timeout/lost write/read Nov 4, 2014
@jmoody jmoody mentioned this pull request Nov 6, 2014
@jmoody jmoody deleted the stability-uia-timeout branch November 6, 2014 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants