Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Docker files into .devcontainer #94

Merged
merged 3 commits into from
May 27, 2022
Merged

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented May 25, 2022

closes #91

What this PR does

  • Moves Docker and related files into .devcontainer, and updates files accordingly
  • Updates docs with instruction to cd into .devcontainer

How to test

  • Run cd .devcontainer and then docker compose --no-cache build server and then docker compose --no-cache build dev
  • Reopen the repository in VS Code Remote Container. Ensure that pre-commit is installed and running.
  • Run the app in Run and Debug mode
  • Run python setup.py - Should run successfully
  • Run coverage run -m pytest -m databasetest - All tests should pass
  • Run source tests/.env.settingstest and then coverage run -m pytest -m settingstest - All tests should pass
  • Test that editing files locally works

@machikoyasuda machikoyasuda requested a review from a team as a code owner May 25, 2022 21:43
@machikoyasuda machikoyasuda self-assigned this May 25, 2022
@machikoyasuda machikoyasuda added the chore Chores and tasks for code cleanup, dev experience, etc. label May 25, 2022
@machikoyasuda machikoyasuda added this to the Courtesy Cards milestone May 25, 2022
@machikoyasuda machikoyasuda requested a review from thekaveman May 25, 2022 23:12
@thekaveman
Copy link
Member

thekaveman commented May 26, 2022

Looking at this.

And it's helping me realize that I messed something up in cal-itp/benefits#598 - the docker compose ... commands don't work unless you have an .env file in the directory, but the instructions / thinking was that the file is optional and only needed for overrides.

EDIT: tracking this in cal-itp/benefits#626

docs/README.md Show resolved Hide resolved
@machikoyasuda machikoyasuda merged commit 4cc4c3e into main May 27, 2022
@machikoyasuda machikoyasuda deleted the chore/91-devcontainer branch May 27, 2022 20:15
@angela-tran angela-tran mentioned this pull request Nov 14, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chores and tasks for code cleanup, dev experience, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor repo with .devcontainer
2 participants