Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dockerfile): add build-essential, so that pre-commit can be installed #85

Merged
merged 1 commit into from
May 25, 2022
Merged

fix(Dockerfile): add build-essential, so that pre-commit can be installed #85

merged 1 commit into from
May 25, 2022

Conversation

machikoyasuda
Copy link
Member

fix #83

@machikoyasuda machikoyasuda added the bug Something isn't working label May 23, 2022
@machikoyasuda machikoyasuda added this to the Courtesy Cards milestone May 23, 2022
@machikoyasuda machikoyasuda self-assigned this May 23, 2022
@machikoyasuda machikoyasuda reopened this May 24, 2022
@machikoyasuda machikoyasuda marked this pull request as draft May 24, 2022 22:59
@machikoyasuda machikoyasuda changed the title fix(Dockerfile): add build-essentials, so that pre-commit can be installed fix(Dockerfile): add build-essential, so that pre-commit can be installed May 24, 2022
@machikoyasuda machikoyasuda mentioned this pull request May 25, 2022
Closed
@machikoyasuda machikoyasuda marked this pull request as ready for review May 25, 2022 01:54
@machikoyasuda machikoyasuda requested a review from a team as a code owner May 25, 2022 01:54
thekaveman
thekaveman approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@machikoyasuda machikoyasuda merged commit 086ccc8 into main May 25, 2022
@machikoyasuda machikoyasuda deleted the fix/83-precommit branch May 25, 2022 20:55
@thekaveman thekaveman mentioned this pull request Aug 29, 2022
Merged
5 tasks
@angela-tran angela-tran mentioned this pull request Nov 14, 2022
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
bug Something isn't working
Projects
None yet
Milestone
Courtesy Cards
Development

Successfully merging this pull request may close these issues.

Local development bug: Pre-commit install error
2 participants
@machikoyasuda @thekaveman