Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: pyproject.toml #280

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Refactor: pyproject.toml #280

merged 3 commits into from
Aug 1, 2023

Conversation

thekaveman
Copy link
Member

Closes #269

@thekaveman thekaveman requested a review from a team as a code owner July 7, 2023 21:37
@thekaveman thekaveman self-assigned this Jul 23, 2023
@thekaveman thekaveman enabled auto-merge July 28, 2023 15:15
@angela-tran
Copy link
Member

👀 Reviewing / testing this

@angela-tran
Copy link
Member

@machikoyasuda Do you want to resolve the conversation above and approve this PR?

@machikoyasuda machikoyasuda self-requested a review August 1, 2023 18:04
machikoyasuda
machikoyasuda approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

slow on first load, might require some refreshes - but works consistently.

@thekaveman thekaveman merged commit ce3acab into dev Aug 1, 2023
@thekaveman thekaveman deleted the refactor/project branch August 1, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran left review comments

@machikoyasuda machikoyasuda machikoyasuda approved these changes

Assignees

@thekaveman thekaveman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate setup into pyproject.toml
3 participants
@thekaveman @angela-tran @machikoyasuda