Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust various security settings in Terraform #202

Merged
merged 5 commits into from
Nov 15, 2022
Merged

adjust various security settings in Terraform #202

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0d8747
fix(Terraform): enable purge protection on the Key Vault
afeld Nov 15, 2022
18576a1
fix(Terraform): set the storage account minimum TLS version
afeld Nov 15, 2022
ae6a348
fix(Terraform): enable HTTP/2
afeld Nov 15, 2022
180f7ae
fix(Terraform): enable better error logging
afeld Nov 15, 2022
73687cb
fix(Terraform): change Vault retention to match current value
afeld Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions terraform/app_service.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ resource "azurerm_linux_web_app" "main" {
https_only = true

site_config {
ftps_state = "Disabled"
ftps_state = "Disabled"
http2_enabled = true

dynamic "ip_restriction" {
for_each = var.IP_ADDRESS_WHITELIST
content {
Expand Down Expand Up @@ -47,8 +49,8 @@ resource "azurerm_linux_web_app" "main" {
}

logs {
detailed_error_messages = false
failed_request_tracing = false
detailed_error_messages = true
failed_request_tracing = true

http_logs {
file_system {
Expand Down
3 changes: 3 additions & 0 deletions terraform/key_vault.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ resource "azurerm_key_vault" "main" {
sku_name = "standard"
tenant_id = data.azurerm_client_config.current.tenant_id

soft_delete_retention_days = 7
purge_protection_enabled = true

# allow engineers to fully manage secrets
access_policy {
tenant_id = data.azurerm_client_config.current.tenant_id
Expand Down
1 change: 1 addition & 0 deletions terraform/storage.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ resource "azurerm_storage_account" "main" {
resource_group_name = data.azurerm_resource_group.main.name
account_tier = "Standard"
account_replication_type = "RAGRS"
min_tls_version = "TLS1_2"

blob_properties {
last_access_time_enabled = true
Expand Down