Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Terraform): add more details around variables #183

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Conversation

afeld
Copy link
Contributor

@afeld afeld commented Nov 8, 2022

No description provided.

@afeld afeld requested a review from angela-tran November 8, 2022 00:43
@afeld afeld requested a review from a team as a code owner November 8, 2022 00:43
VELOCITY_ETL_SERVICE_PRINCIPAL_ID = "..."
```

1. Create a [`terraform.tfvars` file](https://developer.hashicorp.com/terraform/language/values/variables#variable-definitions-tfvars-files) and specify the [variables](variables.tf).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the example so we don't need to manually keep it in sync. When we have the pre-commit in place (#182), we can opt to automatically generate docs.

@angela-tran
Copy link
Member

#185 depends on this

@afeld afeld merged commit 08819ab into dev Nov 8, 2022
@afeld afeld deleted the chore/tfvars-tweaks branch November 8, 2022 20:22
@angela-tran angela-tran mentioned this pull request Nov 14, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants