Chore: specify 8000 as port in launch.json #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machikoyasuda
approved these changes
Aug 31, 2022
thekaveman
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
It doesn't seem to be a problem to add this setting.
I'll just note the change for serving from port 8000 only matters when running the application container served through nginx and gunicorn - for the VS Code / devcontainer use-case, the port can be whatever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@machikoyasuda and I noticed that when launching
eligibility-serverfrom the VS Code debugger, it was being served at 5000 instead of a dynamic port like it used to.Looks like this started happening when the devcontainer's port was changed from 5000 to 8000.
This PR restores the old behavior by specifying in
launch.jsonthat 8000 should be the port for Flask to serve the app at (instead of the default 5000).