Refactor: Database class - remove in-memory data #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
remove now unneeded variable that was holding all users in-memory
angela-tran
force-pushed
the
refactor/database-class--remove-in-memory-data
branch
from
d60f9ad to
f5c1b7e
Compare
|
This PR makes it easier to accomplish #131 |
thekaveman
reviewed
Aug 22, 2022
thekaveman
reviewed
Aug 22, 2022
machikoyasuda
approved these changes
Aug 22, 2022
thekaveman
reviewed
Aug 22, 2022
thekaveman
approved these changes
Aug 23, 2022
angela-tran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers the feedback items in the description of #122:
check_userwhich allows us to remove the_uservariable that was holding all users in-memoryhashbeing used, and split out conditions incheck_userto add logging for each