-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: devcontainer setup #126
Conversation
97ef3c4
to
4facc22
Compare
update git index with file mode for execute
call from both appcontainer start and devcontainer start
4facc22
to
a192078
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work - the dev experience is more consistent now 💯
Tested locally by:
- running
cp .devcontainer/.env .env
- rebuilding the
server
image withdocker compose build server
- choosing
Rebuild and Reopen in Container
in VS Code
@machikoyasuda want to make sure you see this and can run the containers without any issue! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this PR or in a subsequent PR, the docs need to be updated to remove cd .devcontainer
and note that setup.py
is happening at app start. Otherwise, works great: I was able to move my .env file, build a new container, Rebuild and Reopen in Container, run the app, healthcheck and run all tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Cleans up the devcontainer setup and normalizes with
benefits
:compose.yml
file to the root, sodocker compose
commands can be run from there.env
fileThe file will need to move from inside the
.devcontainer/
directory to the root of the repository