Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: devcontainer setup #126

Merged
merged 11 commits into from
Aug 17, 2022
Merged

Chore: devcontainer setup #126

merged 11 commits into from
Aug 17, 2022

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Aug 16, 2022

Cleans up the devcontainer setup and normalizes with benefits:

⚠️ Devs should update their .env file

The file will need to move from inside the .devcontainer/ directory to the root of the repository

@thekaveman thekaveman requested a review from a team as a code owner August 16, 2022 01:00
@thekaveman thekaveman marked this pull request as draft August 16, 2022 01:00
@thekaveman thekaveman added this to the Courtesy Cards milestone Aug 16, 2022
@thekaveman thekaveman added the chore Chores and tasks for code cleanup, dev experience, etc. label Aug 16, 2022
@thekaveman thekaveman force-pushed the chore/devcontainer-setup branch from 97ef3c4 to 4facc22 Compare August 16, 2022 01:11
Base automatically changed from refactor/settings to main August 16, 2022 16:22
@thekaveman thekaveman force-pushed the chore/devcontainer-setup branch from 4facc22 to a192078 Compare August 16, 2022 16:33
@thekaveman thekaveman marked this pull request as ready for review August 16, 2022 16:34
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work - the dev experience is more consistent now 💯

Tested locally by:

  • running cp .devcontainer/.env .env
  • rebuilding the server image with docker compose build server
  • choosing Rebuild and Reopen in Container in VS Code

@thekaveman
Copy link
Member Author

@machikoyasuda want to make sure you see this and can run the containers without any issue!

Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR or in a subsequent PR, the docs need to be updated to remove cd .devcontainer and note that setup.py is happening at app start. Otherwise, works great: I was able to move my .env file, build a new container, Rebuild and Reopen in Container, run the app, healthcheck and run all tests.

Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@thekaveman thekaveman merged commit a75e522 into main Aug 17, 2022
@thekaveman thekaveman deleted the chore/devcontainer-setup branch August 17, 2022 23:25
@thekaveman thekaveman self-assigned this Aug 24, 2022
@angela-tran angela-tran mentioned this pull request Nov 14, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chores and tasks for code cleanup, dev experience, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run setup.py on devcontainer attach Normalize devcontainer settings/extensions with benefits
3 participants