Feat: production container #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
thekaveman
force-pushed
the
feat/production-container
branch
from
a713765 to
a456940
Compare
thekaveman
force-pushed
the
chore/devcontainer-setup
branch
from
97ef3c4 to
4facc22
Compare
thekaveman
force-pushed
the
feat/production-container
branch
from
a456940 to
5d37d95
Compare
thekaveman
force-pushed
the
chore/devcontainer-setup
branch
from
4facc22 to
a192078
Compare
thekaveman
force-pushed
the
feat/production-container
branch
from
5d37d95 to
8483950
Compare
thekaveman
force-pushed
the
feat/production-container
branch
from
8483950 to
4b76dbc
Compare
thekaveman
force-pushed
the
feat/production-container
branch
from
547792a to
00082f6
Compare
nginx listens on this port
thekaveman
force-pushed
the
feat/production-container
branch
from
00082f6 to
f610a12
Compare
machikoyasuda
approved these changes
Aug 22, 2022
angela-tran
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
I was also able to rebuild and reopen the devcontainer, and I could run the server container with docker compose.
Created cal-itp/docker-python-web#2 as a part of reviewing this
This was referenced Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #111
This PR changes the base image to use our new
cal-itp/docker-python-webimage hosted on GitHub Container Registry.This base image bakes in
nginxandgunicorn- andbin/start.shruns the app through those services.Developers shouldn't notice a difference running the app locally - either inside the devcontainer in debug mode, or by running the container with
docker compose.