Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure pytest and test healthcheck #11

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Sep 30, 2021

closes #4

What this PR does:

  • Add pytest and coverage to development Docker image
  • Configure pytest (in the most basic way possible)
  • Create 1 test, testing healthcheck endpoint

Run this PR:

  • Rebuild and Reopen in Container
  • Run pytest

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to rebuild the devcontainer and run pytest!

One note, the earlier trouble with import may be related to the fact that the app.py module is sitting in the root of the repository. Normally modules are inside a directory that contains an __init__.py file and imported like:

from directory import module

I'll note this in a separate issue. See #12

@machikoyasuda machikoyasuda merged commit f18ce45 into main Oct 1, 2021
@machikoyasuda machikoyasuda deleted the testing-healthcheck branch October 1, 2021 17:24
@thekaveman thekaveman added this to the October 2021 milestone Oct 6, 2021
@angela-tran angela-tran mentioned this pull request Nov 14, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial testing
2 participants