CSV configuration variables #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icolon in .env file, cast CSV_QUOTING as integer
|
@machikoyasuda and I learned today that |
thekaveman
approved these changes
Aug 5, 2022
angela-tran
approved these changes
Aug 5, 2022
|
|
||
| ## Set up database and run tests | ||
| Starting the Dev Container will run `bin/start.sh`, which runs `setup.py` and starts the Flask app. The `setup.py` script creates a table, imports and saves users from a JSON or CSV file specified in the .env file from the `IMPORT_FILE_PATH` key. CSV files will require |
There was a problem hiding this comment.
Thank you for updating these docs! Especially with the part about bin/start.sh, which I missed in #101.
I don't want to block this PR, but I noticed this fragment CSV files will require. Maybe we can finish it out or remove it as a follow-up.
There was a problem hiding this comment.
Will take care of this in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #62
What this PR does
Adds the following environment variables to allow developers to configure the CSV file. Updates .env.sample and .env.settingstest to reflect new variables. Configures values to be compatible with
python setup.pyand the pytests. Updates documentation.Up next: Refactoring the way settings are configured, #109, so that it is easier to write pytests for different configuration scenarios.
Environment variables
These variables come straight from https://docs.python.org/3/library/csv.html#examples