-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: idempotent setup and teardown #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find and nice simple fix 👍
In setup.py
, should there be one more check to see if, when the table already exists, it still needs users to be loaded? Not sure if that's a use case that matters...
I could see a case where maybe the I think I'll also add a print statement for the case where data wasn't loaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Maybe a follow-up: figure out how to get the Python logging
framework configured and replace the print
statements with more appropriate log-level statements.
Closes #103