Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup/teardown logging #139

Closed
angela-tran opened this issue Aug 26, 2022 · 0 comments · Fixed by #140
Closed

Fix setup/teardown logging #139

angela-tran opened this issue Aug 26, 2022 · 0 comments · Fixed by #140
Labels
bug Something isn't working

Comments

@angela-tran
Copy link
Member

angela-tran commented Aug 26, 2022

After #128 was merged in, the setup and teardown scripts are no longer showing log statements in the console:

Additional context

This has to do with logger hierarchy. In #116, we were setting the log level and handler for the root logger. The intent in #128 was to:

  • introduce a configurable setting for the log level
  • simplify the configuration code (avoid adding/removing redundant handlers)

I thought configuring directly on the app.logger instance would be equivalent to our previous setup, but I see now that's not true.

This bug points out that we should revisit the organization of our scripts and where they get their Logger. This might have some overlap with #131.

Resources

https://docs.python.org/3/howto/logging.html#advanced-logging-tutorial

@angela-tran angela-tran added the bug Something isn't working label Aug 26, 2022
@thekaveman thekaveman moved this to Backlog in Digital Services Aug 29, 2022
Repository owner moved this from Backlog to Done in Digital Services Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant